Hi Russell, > -----Original Message----- > From: Russell King [mailto:rmk@xxxxxxxxxxxxxxxx] > Sent: Wednesday, September 23, 2009 3:26 PM > To: C.A, Subramaniam > Cc: linux-omap@xxxxxxxxxxxxxxx; Hiroshi DOYU; > tony@xxxxxxxxxxx; Kanigeri, Hari; Gupta, Ramesh > Subject: Re: [PATCH 8/10] omap mailbox: OMAP4-Mailbox - Adds > code changes to support OMAP4 mailbox. > > On Tue, Sep 22, 2009 at 08:03:32PM +0530, C.A, Subramaniam wrote: > > @@ -70,10 +88,9 @@ static inline void mbox_write_reg(u32 > val, size_t ofs) > > static int omap2_mbox_startup(struct omap_mbox *mbox) > > { > > unsigned int l; > > - > > mbox_ick_handle = clk_get(NULL, "mailboxes_ick"); > > if (IS_ERR(mbox_ick_handle)) { > > - printk("Could not get mailboxes_ick\n"); > > + printk(KERN_ERR "Could not get mailboxes_ick\n"); > > return -ENODEV; > > Good idea: Print the error code so people can diagnose why > things fail. > > printk(KERN_ERR "Could not get mailboxes_ick: %d\n", > PTR_ERR(mbox_ick_handle)); > > And wonder why this hasn't been spotted before. > > Rule: always propagate error codes when you have one to propagate. > > return PTR_ERR(mbox_ick_handle); Thank you for your comments. I will send a revised patch. Regards Subbu-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
