>-----Original Message----- >From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of >Gadiyar, Anand >Sent: Thursday, September 24, 2009 6:08 AM >To: linux-omap@xxxxxxxxxxxxxxx >Subject: Build break on mainline tree for 3430 SDP > >Build break compiling Linus' git tree for 3430 SDP. > >I get this with the default SDP config. Haven't looked at the >code yet to find a fix. > >- Anand > > CC arch/arm/mach-omap2/board-3430sdp.o >In file included from arch/arm/mach-omap2/board-3430sdp.c:41: >arch/arm/plat-omap/include/mach/keypad.h:38:1: warning: "KEY" redefined >In file included from include/linux/i2c/twl4030.h:29, > from arch/arm/mach-omap2/board-3430sdp.c:22: >include/linux/input/matrix_keypad.h:10:1: warning: this is the location of the previous definition >In file included from arch/arm/mach-omap2/board-3430sdp.c:41: >arch/arm/plat-omap/include/mach/keypad.h:39:1: warning: "PERSISTENT_KEY" redefined >In file included from arch/arm/mach-omap2/board-3430sdp.c:22: >include/linux/i2c/twl4030.h:356:1: warning: this is the location of the previous definition >arch/arm/mach-omap2/board-3430sdp.c:94: error: unknown field 'keymap' specified in initializer >arch/arm/mach-omap2/board-3430sdp.c:94: warning: the address of 'sdp3430_keymap' will always evaluate >as 'true' >arch/arm/mach-omap2/board-3430sdp.c:95: error: unknown field 'keymapsize' specified in initializer >arch/arm/mach-omap2/board-3430sdp.c:95: warning: excess elements in struct initializer >arch/arm/mach-omap2/board-3430sdp.c:95: warning: (near initialization for 'sdp3430_kp_data') >make[1]: *** [arch/arm/mach-omap2/board-3430sdp.o] Error 1 >make: *** [arch/arm/mach-omap2] Error 2 Linus tree has more up-to-date commit on include/linux/i2c/twl4030.h That changes the keymap interface. const struct matrix_keymap_data *keymap_data; See the highlighted line below. All boards may have to adapt to the new keymap interface. commit 9d8340687c524ce61e3c9c76758c4c81303acfc0 Author: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> Date: Tue Aug 25 19:24:14 2009 -0700 Input: add twl4030_keypad driver Add a driver for the keypad controller on TWL4030 family chips. These support up to an 8x8 key matrix. The TWL4030 multifunction chips are mostly used on OMAP3 (or OMAP 2430) based boards. >>>> [dtor@xxxxxxx: switch to matrix-keypad framework, fix changing keymap from userspace] Reviewed-by: Trilok Soni <soni.trilok@xxxxxxxxx> Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx> > >-- >To unsubscribe from this list: send the line "unsubscribe linux-omap" in >the body of a message to majordomo@xxxxxxxxxxxxxxx >More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
