RE: [PATCH] ARM: OMAP: Add omap34xx revision detection for ES3.1.1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tony Lindgren wrote:
> * Anand Gadiyar <gadiyar@xxxxxx> [090826 05:04]:
> > ARM: OMAP: Add omap34xx revision detection for ES3.1.1
> > 
> > - Add omap34xx revision detection for ES3.1.1 silicon.
> > - Change default silicon to ES3.1.1
> > 
> > - Also minor bug-fix: ES2.0 rev field is 1, not 0.
> >   - This means that ES2.0 silicon would have wrongly been
> >     detected as unknown
> > 
> > Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx>
> > ---
> > Let me know if this should be split into a bug-fix patch,
> > and a separate patch for adding ES 3.1.1 revision info.
> > I felt the change was too minor to split out, since
> > ES2.0 silicon is rare.
> > 
> > This patch is against linus' tree - so the cpu.h
> > change will apply with an offset
> > 
> >  arch/arm/mach-omap2/id.c              |    8 ++++++--
> >  arch/arm/plat-omap/include/mach/cpu.h |    1 +
> >  2 files changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> > index a98201c..414c520 100644
> > --- a/arch/arm/mach-omap2/id.c
> > +++ b/arch/arm/mach-omap2/id.c
> > @@ -185,7 +185,7 @@ void __init omap34xx_check_revision(void)
> >  
> >  	if (hawkeye == 0xb7ae) {
> >  		switch (rev) {
> > -		case 0:
> > +		case 1:
> >  			omap_revision = OMAP3430_REV_ES2_0;
> >  			rev_name = "ES2.0";
> >  			break;
> 
> Are you sure about this change? Can you please check on real
> ES2.0 hardware, I believe the TRM may have a typo.
> 
> Regards,
> 
> Tony
> 

No, I'm not sure. I only caught it when I looked at the TRM to get
the ES3.1.1 ID.

I'll have to dig up an ES2.0 board to really verify, but that
won't happen for a couple of weeks at least.

If someone has this board around, please test and report.

Thanks,
Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux