* Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> [090918 07:54]: > Hi Premi, > > From: "ext Premi, Sanjeev" <premi@xxxxxx> > Subject: RE: [PATCH] OMAP3: iovmm: fix compiler warning > Date: Fri, 18 Sep 2009 16:40:29 +0200 > > [...] > > > > > > @@ -390,7 +391,7 @@ static void sgtable_fill_vmalloc(struct > > > > sg_table *sgt, void *_va) > > > > > } > > > > > > > > > > va_end = _va + PAGE_SIZE * i; > > > > > - flush_cache_vmap(_va, va_end); > > > > > + flush_cache_vmap((unsigned long) _va, (unsigned long) va_end); > > > > > } > > > > > > > > > > static inline void sgtable_drain_vmalloc(struct sg_table *sgt) > > > > > > > > If no need for pointer, what about below? > > > > > > I did not check for the usage of sgtable_drain_vmalloc(). > > > Yes. If the void* isn't MUST then, change below is fine. > > > > > > ~sanjeev > > > > On second look, the need for void* is driven backwards from: > > pg = vmalloc_to_page(va); > > In function sgtable_fill_vmalloc(). > > > > Now we need a typecast from u32 to void*. > > > > Shouldn't we go with the original patch itself? > > Right, the original is better, then;) Can you please specify which one (if any) should be queued? Do you mean http://patchwork.kernel.org/patch/48467/ Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
