RE: [APPLIED] [PATCH] omapfb: Reorder Register_framebuffer call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: linux-omap-owner@xxxxxxxxxxxxxxx [linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Angelo Arrifano [miknix@xxxxxxxxx]
Sent: Tuesday, September 22, 2009 12:21 PM
> To: Tony Lindgren
> Cc: Alistair Buxton; linux-omap@xxxxxxxxxxxxxxx
> Subject: Re: [APPLIED] [PATCH] omapfb: Reorder Register_framebuffer call
> 
> Tony Lindgren wrote:
> > * Jan Blunck <jblunck@xxxxxxxxxxxxx> [090922 07:59]:
> >> On Tue, Sep 22, 2009 at 3:31 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> >>> This patch has been applied to the linux-omap
> >>> by youw fwiendly patch wobot.
> >>>
> >>> Branch in linux-omap: omap-fixes
> >>>
> >>> Initial commit ID (Likely to change): 9aef1066fb5ca8506068eaab1c552ecca4c85475
> >>>
> >>> PatchWorks
> >>> http://patchwork.kernel.org/patch/47089/
> >>>
> >
> > Added back the original Cc's that were dropped from the linux-omap
> > commit message.
> >
> >> Is it actually safe to do this? The framebuffer can be used directly
> >> after it is registered. In this case it would mean it is used before
> >> it is even fully initialized (set_fb_var(), set_fb_fix(), ... are
> >> being called).
> >
> > Good point, dropping the patch.
> >
> > Also, let's let Tomi Valkeinen deal with queueing up the omap fb code.
> > I can then merge Tomi's branck into linux-omap master branch as needed.
> >
> > Regards,
> >
> > Tony
> 
> Hello,
> 
> This patch doesn't work for us at linwizard project (omap850). The
> commit 537a1bf059fa312355696fa6db80726e655e7f17 makes the HTC Wizard
> crash at boot due to usage of uninitialized mutex. Applying the referred
> patch prevents the crash but the LCD screen goes black and doesn't show
> any data.

Angelo,


Some people gave his ACK, because it was booting. and also i kept it since some framebuffer tests in my 3430SDP passed (i.e. it was showing the intended data.)

However, didn't show the Tux during bootup. Isn't the same case as you?

Anyways, Thanks for sharing your results... I'll rework this patch and resend once i'm done.

Regards,
Sergio
> 
> - Angelo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux