Kevin Hilman wrote:
Mike Chan <mike@xxxxxxxxxxx> writes:
Need to lock the res_mutex when traversing the res_list.
Signed-off-by: Mike Chan <mike@xxxxxxxxxxx>
Looks good, thanks.
This patch causes a hang for me when transitioning to OFF mode. This
was tested on the Android 2.6.29 tree and is 100% reproducible. The
moment a user runs 'echo 1 > /sys/power/enable_off_mode' the board hangs
without any further output.
Reverting the patch allows me to hit OFF mode again. I haven't yet
tested this on vanilla 2.6.29 or latest L-O.
Mike
Pushed to PM branch and pm-2.6.29.
Kevin
---
arch/arm/plat-omap/resource.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/resource.c b/arch/arm/plat-omap/resource.c
index 25072cd..4631912 100644
--- a/arch/arm/plat-omap/resource.c
+++ b/arch/arm/plat-omap/resource.c
@@ -234,11 +234,13 @@ int resource_refresh(void)
struct shared_resource *resp = NULL;
int ret = 0;
+ down(&res_mutex);
list_for_each_entry(resp, &res_list, node) {
ret = update_resource_level(resp);
if (ret)
break;
}
+ up(&res_mutex);
return ret;
}
--
1.5.4.5
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
