Hi Russell, 'arg' is used later in Patch 10, as part of the tasklet implementation, for writing messages to the mailbox. Should I be removing it in patch 6 and introduce it only for the tasklet implementation? Thank you and regards Subbu > -----Original Message----- > From: Russell King [mailto:rmk@xxxxxxxxxxxxxxxx] > Sent: Monday, September 07, 2009 8:33 PM > To: C.A, Subramaniam > Cc: linux-omap@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx; > Hiroshi.DOYU@xxxxxxxxx; Kanigeri, Hari; Gupta, Ramesh > Subject: Re: [PATCH 6/10] omap mailbox: remove unnecessary > arg for omap_mbox_msg_send > > On Fri, Sep 04, 2009 at 05:18:04PM +0530, C.A, Subramaniam wrote: > > @@ -114,7 +114,6 @@ int omap_mbox_msg_send(struct omap_mbox > *mbox, mbox_msg_t msg, void* arg) > > } > > > > tx_data->msg = msg; > > - tx_data->arg = arg; > > What about also removing 'arg' from struct omap_msg_tx_data ? > > -- > Russell King > Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ > maintainer of: > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
