Hi Hiroshi, > -----Original Message----- > From: Hiroshi DOYU [mailto:Hiroshi.DOYU@xxxxxxxxx] > Sent: Monday, September 07, 2009 2:03 PM > To: C.A, Subramaniam > Cc: linux-omap@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx; > rmk@xxxxxxxxxxxxxxxx; Kanigeri, Hari; Gupta, Ramesh > Subject: Re: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add > build specific changes to support OMAP4 mailbox. > > From: "ext C.A, Subramaniam" <subramaniam.ca@xxxxxx> > Subject: RE: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add > build specific changes to support OMAP4 mailbox. > Date: Mon, 7 Sep 2009 10:27:22 +0200 > > > > > > > > > Signed-off-by: C A Subramaniam <subramaniam.ca@xxxxxx> > > > > Signed-off-by: Ramesh Gupta G <grgupta@xxxxxx> > > > > --- > > > > arch/arm/mach-omap2/Makefile | 4 ++++ > > > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/arch/arm/mach-omap2/Makefile > > > > b/arch/arm/mach-omap2/Makefile index 735bae5..4bb426d 100644 > > > > --- a/arch/arm/mach-omap2/Makefile > > > > +++ b/arch/arm/mach-omap2/Makefile > > > > @@ -39,6 +39,10 @@ endif > > > > obj-$(CONFIG_ARCH_OMAP2) += clock24xx.o > > > > obj-$(CONFIG_ARCH_OMAP3) += clock34xx.o > > > > > > > > +# MAILBOX > > > > > > I think that the above line is not necessary since the > module names > > > are enough self-explanatory, a little bit nitpicky, though.... > > > > I have followed the existing convention present in the > Makefile (Power management, clock framework,etc.) as follows: > > > > # Power Management > > ifeq ($(CONFIG_PM),y) > > obj-$(CONFIG_ARCH_OMAP2) += pm24xx.o > > obj-$(CONFIG_ARCH_OMAP24XX) += sleep24xx.o > > obj-$(CONFIG_ARCH_OMAP3) += pm34xx.o sleep34xx.o > > obj-$(CONFIG_PM_DEBUG) += pm-debug.o > > endif > > > > # Clock framework > > obj-$(CONFIG_ARCH_OMAP2) += clock24xx.o > > obj-$(CONFIG_ARCH_OMAP3) += clock34xx.o > > > > Please let me know if you still believe that the line needs > to be removed. > > I understand that you followed kind of convention, but I > still think that these comments don't make so much sense > since these module names are apparently enough self-explanatory. > > Sure! I can remove that. I will send a patch with the changes you had mentioned.-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
