Hi Subramaniam, From: "ext C.A, Subramaniam" <subramaniam.ca@xxxxxx> Subject: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add build specific changes to support OMAP4 mailbox. Date: Fri, 4 Sep 2009 13:47:09 +0200 > From aa759db084be9a2893de5e61b11f6de6d05508d9 Mon Sep 17 00:00:00 2001 > From: C A Subramaniam <subramaniam.ca@xxxxxx> > Date: Wed, 2 Sep 2009 17:52:22 +0530 > Subject: [PATCH 1/10] omap mailbox: OMAP4-Mailbox - Add build specific changes to support OMAP4 mailbox. > > This patch adds changes to the build related files of mailbox > driver to support OMAP4 mailbox The above comment doesn't match the this modification since adding those module isn't just for OMAP4, but for other omap architecutres(omap2/3/4). So I think that this explanation should be changed as not only for omap4, but just for adding common mailbox support in this Makefile. > > Signed-off-by: C A Subramaniam <subramaniam.ca@xxxxxx> > Signed-off-by: Ramesh Gupta G <grgupta@xxxxxx> > --- > arch/arm/mach-omap2/Makefile | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile > index 735bae5..4bb426d 100644 > --- a/arch/arm/mach-omap2/Makefile > +++ b/arch/arm/mach-omap2/Makefile > @@ -39,6 +39,10 @@ endif > obj-$(CONFIG_ARCH_OMAP2) += clock24xx.o > obj-$(CONFIG_ARCH_OMAP3) += clock34xx.o > > +# MAILBOX I think that the above line is not necessary since the module names are enough self-explanatory, a little bit nitpicky, though.... > +obj-$(CONFIG_OMAP_MBOX_FWK) += mailbox_mach.o > +mailbox_mach-objs := mailbox.o > + > iommu-y += iommu2.o > iommu-$(CONFIG_ARCH_OMAP3) += omap3-iommu.o > > -- > 1.5.3.2 > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
