Hi, Paul I resent the patch after fix the format issue. Please help to review it. Thanks Janboe 2009/8/28 Paul Walmsley <paul@xxxxxxxxx>: > Hello janboe, > > On Fri, 28 Aug 2009, ye janboe wrote: > >> >From f10090bf307066f1317d7152c6f9a6f395007d4a Mon Sep 17 00:00:00 2001 >> From: janboe <janboe.ye@xxxxxxxxx> >> Date: Fri, 28 Aug 2009 13:50:57 +0800 >> Subject: [PATCH] flush the function in sdram is not correct because >> sram is changed. >> >> Signed-off-by: janboe <janboe.ye@xxxxxxxxx> > > The technical part of the patch makes sense, but the patch format needs > to be changed. > > Your subject line should start with something like "[PATCH] OMAP SRAM:", > and you should add a short patch description that describes the bug and > why the patch does what it does to fix it. > > Also your post should not include the "From", "Date", and "Subject" lines > inside the E-mail. You might wish to consider using 'git send-email' or > at least 'git format-patch' if possible. > > > - Paul > >> --- >> arch/arm/plat-omap/sram.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c >> index f2b0fa6..253fcf7 100644 >> --- a/arch/arm/plat-omap/sram.c >> +++ b/arch/arm/plat-omap/sram.c >> @@ -270,7 +270,7 @@ void * omap_sram_push(void * start, unsigned long size) >> omap_sram_ceil -= size; >> omap_sram_ceil = ROUND_DOWN(omap_sram_ceil, sizeof(void *)); >> memcpy((void *)omap_sram_ceil, start, size); >> - flush_icache_range((unsigned long)start, (unsigned long)(start + size)); >> + flush_icache_range((unsigned long)omap_sram_ceil, (unsigned >> long)(omap_sram_ceil + size)); >> >> return (void *)omap_sram_ceil; >> } >> -- >> 1.6.3.3 >> > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
