RE: [PATCH] MUSB: Remove usb_musb_pm_init() call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > MUSB: Remove usb_musb_pm_init() call
> >
> > In usb_musb_pm_init, we attempt to access an MUSB register
> > when the i-clock may not be on, or the module is otherwise
> > not accessible.
> >
> > We need to either:
> > - enable the clock before this access, or
> > - remove this code and move it to the bootloader, or
> > - enable the clock in the bootloader
> >
> > If we enable the clock in the bootloader, we might as well
> > add the workaround in the bootloader itself. This code will
> > anyway be changed once hwmod is in place, so remove it for now
> >
> > This allows us to boot the kernel on certain OMAP3 boards with
> > a bootloader that doesn't enable this clock. Without this, we
> > will need to upgrade the bootloaders on these boards.
> >
> > Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx>
> 
> NAK.
> 
> The PM branch already has a fix from Jon Hunter[1] for this which enables
> the clock, and in the thread where we discussed this I mentioned I would
> carry it in the PM branch until the hwmod for OTG is ready.

Right, but at least merge this into master and mainline for now,
so that boards that used to boot up okay before can continue to do so now.

Not everybody is working on the pm branch.

- Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux