RE: [RFC][PATCH 0/3] RTC platform data structure defined

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Kevin Hilman
> Sent: Saturday, August 22, 2009 9:58 PM
> To: Varadarajan, Charu Latha
> Cc: linux-omap@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx; david-b@xxxxxxxxxxx;
> sameo@xxxxxxxxxxxxxxx; p_gortmaker@xxxxxxxxx
> Subject: Re: [RFC][PATCH 0/3] RTC platform data structure defined
>
> charu@xxxxxx writes:
>
> > This series contains patches which
> >         1. define TWL4030 rtc platform data which has msecure gpio line
> info
> >         2. initialise msecure gpio line from rtc driver
> >         3. twl core file passes rtc platform data from board file to rtc
> driver
> >         4. Board files handle mux configuration of msecure gpio line
> >
> > This series applies on top of linux-2.6.31-rc5.
> >
> > CharuLatha (4):
> >
> >         [PATCH 0/3] RTC platform data structure defined
>
> Normally, PATCH 0/n is a summary of the other patches, and does not
> include a patch itself.
>
> I recommend using 'git format-patch' which will take care of the
> formatting and the numbering for you.
>
Okay. I will take care hereafter.
> >         [PATCH 1/3] RTC periodic interrupts enabling and msecure init
> >         [PATCH 2/3] handling rtc platform data
> >         [PATCH 3/3] board files do msecure line mux configuration
> >
> > Structure "twl4030_rtc_platform_data" is defined with msecure_gpio in
> it.
> > This structure would be initialised in board file.
> > RTC msecure line initialization happens in RTC driver.
> > The same structure can be used for any future enhancements in RTC.
> >
> >
> > Signed-off-by: Charulatha V <charu@xxxxxx>
> > ---
> >  include/linux/i2c/twl4030.h |    8 ++++++++
> >  1 files changed, 8 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/i2c/twl4030.h b/include/linux/i2c/twl4030.h
> > index 15edfaa..6ae582b 100644
> > --- a/include/linux/i2c/twl4030.h
> > +++ b/include/linux/i2c/twl4030.h
> > @@ -341,6 +341,13 @@ struct twl4030_gpio_platform_data {
> >                             unsigned gpio, unsigned ngpio);
> >  };
> >
> > +struct twl4030_rtc_platform_data {
> > +   int             msecure_gpio;
> > +   /* More structures/elements can be added
> > +    * for future Triton RTC driver enhancements
> > +    */
>
> very true, but does not need to be documented.
>
Agreed.
> > +};
> > +
> >  struct twl4030_madc_platform_data {
> >     int             irq_line;
> >  };
> > @@ -395,6 +402,7 @@ struct twl4030_platform_data {
> >     unsigned                                irq_base, irq_end;
> >     struct twl4030_bci_platform_data        *bci;
> >     struct twl4030_gpio_platform_data       *gpio;
> > +   struct twl4030_rtc_platform_data        *rtc;
> >     struct twl4030_madc_platform_data       *madc;
> >     struct twl4030_keypad_data              *keypad;
> >     struct twl4030_usb_data                 *usb;
> > --
> > 1.6.0.4
> >
> > --
>
> Kevin
> --


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux