Hi Andrew, On Thu, 2025-02-27 at 14:24 +0100, Andrew Lunn wrote: > On Thu, Feb 27, 2025 at 08:46:46AM +0100, A. Sverdlin wrote: > > From: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx> > > > > So that of_find_net_device_by_node() can find cpsw-nuss ports and other DSA ^^^^^ Oops, copy-paste failure here, nuss was for the am65-cpsw-nuss driver, maybe "-nuss" could be simply deleted from the commit message on "apply"... > > switches can be stacked downstream. Tested in conjunction with KSZ8873. > > > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx> > > Consistent with other TI drivers. But it looks like only TI drivers > need this, which suggests they are all doing something wrong, maybe > for legacy reasons. Well, yes, they re-invent the wheel, mimicking the DSA infrastructure without using it. CPSW is a switch, as the name suggests, but the effort has not been spent to bring it to DSA home ;-) So what happens here actually is, I'm assigning a DT node to "user port" in DSA terms, and dsa_register_switch() would for sure do it... > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> -- Alexander Sverdlin Siemens AG www.siemens.com