Re: [PATCH v4 2/5] regulator: dt-bindings: Add TI TPS65214 PMIC bindings

[Shree Ramamoorthy <s-ramamoorthy@xxxxxx>]

Hi,

On 2/1/25 5:42 AM, Krzysztof Kozlowski wrote:
> On 31/01/2025 23:11, Shree Ramamoorthy wrote:
> >   
> > @@ -98,6 +102,16 @@ required:
> >   additionalProperties: false
> >   
> >   allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: ti,tps65214
> > +    then:
> > +      properties:
> > +        regulators:
> > +          patternProperties:
> > +            "^ldo[3-4]$": false
> So now, when you combined these patches, you can easily see that you are
> duplicating your other "then:" from patch #1. Just combine these into
> enum. Don't duplicate.
>
> Best regards,
> Krzysztof

Thank you for reviewing! I'll add in this feedback, and send a v5 soon pending any other feedback.


--
Best,
Shree Ramamoorthy
PMIC Software Engineer