Re: [PATCH] fbdev: omapfb: Fix an OF node leak in dss_of_port_get_parent_device()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



You missed to CC fbdev mailing list.

On 1/9/25 00:03, Laurent Pinchart wrote:
On Wed, Jan 08, 2025 at 10:15:37AM +0900, Joe Hattori wrote:
dss_of_port_get_parent_device() leaks an OF node reference when i >= 2
and struct device_node *np is present. Since of_get_next_parent()
obtains a reference of the returned OF node, call of_node_put() before
returning NULL.

This was found by an experimental verifier that I am developing, and no
runtime test was able to be performed due to that lack of actual
devices.

Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
Signed-off-by: Joe Hattori <joe@xxxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

---
  drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 1 +
  1 file changed, 1 insertion(+)

Applied to fbdev git tree.
Please speak up if you want to take it through another tree.

Helge







[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux