Le 14/11/2024 à 16:08, Roger Quadros a écrit :
>
>
> On 14/11/2024 15:50, Romain Naour wrote:
>> Hi Roger, Robin, All,
>>
>> Le 14/11/2024 à 12:02, Roger Quadros a écrit :
[...]
>>
>> Thanks for your reply!
>>
>> It seems l4_cfg can inherit dma-ranges property from ocp node using
>> "dma-ranges;". But then segment@100000 node (0x4a100000) needs "dma-ranges;" too.
>>
>> With the following patch applied, the SATA drive works correctly.
>>
>> diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
>> index 1aaffd034c39..3ac770298844 100644
>> --- a/arch/arm/boot/dts/dra7-l4.dtsi
>> +++ b/arch/arm/boot/dts/dra7-l4.dtsi
>> @@ -12,6 +12,7 @@ &l4_cfg { /*
>> 0x4a000000 */
>> ranges = <0x00000000 0x4a000000 0x100000>, /* segment 0 */
>> <0x00100000 0x4a100000 0x100000>, /* segment 1 */
>> <0x00200000 0x4a200000 0x100000>; /* segment 2 */
>> + dma-ranges;
>>
>> segment@0 { /* 0x4a000000 */
>> compatible = "simple-pm-bus";
>> @@ -557,6 +558,7 @@ segment@100000 { /*
>> 0x4a100000 */
>> <0x0007e000 0x0017e000 0x001000>, /* ap 124 */
>> <0x00059000 0x00159000 0x001000>, /* ap 125 */
>> <0x0005a000 0x0015a000 0x001000>; /* ap 126 */
>> + dma-ranges;
>>
>> target-module@2000 { /* 0x4a102000, ap 27 3c.0 */
>> compatible = "ti,sysc";
>>
>>
>> Sorry, I'm not familliar with property inheritance between devicetree nodes,
>> especially with dma-ranges. Does this change seem correct to you?
>
> I think this is correct.
> A similar fix [4] was done for PCIe as well.
>
> [4] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=90d4d3f4ea45370d482fa609dbae4d2281b4074f
Thank you for your help, I just sent the patch:
https://lore.kernel.org/linux-omap/20241114155759.1155567-1-romain.naour@xxxxxxxx/T/#u
Best regards,
Romain
>
>>
>> Best regards,
>> Romain
