On Mon, 28 Oct 2024 at 14:46, H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> wrote: > > Hi Robin, > > > Am 28.10.2024 um 18:58 schrieb Robin Murphy <robin.murphy@xxxxxxx>: > > > > Hi all, > > > > It seems omap-iommu hasn't had enough mainline users to avoid bitrotting > > through the more recent evolution of the IOMMU API internals. These > > patches attempt to bring it and its consumers sufficiently up-to-date > > to work again, in a manner that's hopefully backportable. This is > > largely all written by inspection, but I have managed to lightly boot > > test patch #3 on an OMAP4 Pandaboard to confirm iommu_probe_device() > > working again. > > > > This supersedes my previous patch[1]. Patches #1 and #2 are functionally > > independent, and can be applied directly to their respective trees if > > preferred. > > I can confirm that this series works on omap3 with v6.12-rc5 and > Camera is back to the GTA04. > > So you can add: > Tested-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> > Many thanks for taking the time to test this, it is really appreciated. > BR and thanks, > Nikolaus > > root@letux:~# dmesg|fgrep iommu > [ 0.522613] iommu: Default domain type: Translated > [ 0.522644] iommu: DMA domain TLB invalidation policy: strict mode > [ 0.525177] omap-iommu 480bd400.mmu: 480bd400.mmu registered > [ 10.752563] omap3isp 480bc000.isp: Adding to iommu group 0 > [ 10.811218] omap-iommu 480bd400.mmu: 480bd400.mmu: version 1.1 > [ 11.039489] omap-iommu 480bd400.mmu: 480bd400.mmu: version 1.1 > root@letux:~# dmesg|fgrep .isp > [ 10.752563] omap3isp 480bc000.isp: Adding to iommu group 0 > [ 10.841522] omap3isp 480bc000.isp: supply vdd-csiphy1 not found, using dummy regulator > [ 10.948577] omap3isp 480bc000.isp: supply vdd-csiphy2 not found, using dummy regulator > [ 10.990814] omap3isp 480bc000.isp: Revision 15.0 found > [ 11.089324] omap3isp 480bc000.isp: hist: using DMA channel dma0chan15 > [ 11.115905] omap3isp 480bc000.isp: Entity type for entity OMAP3 ISP CCP2 was not initialized! > [ 11.168792] omap3isp 480bc000.isp: isp_xclk_set_rate: cam_xclka set to 24685714 Hz (div 7) > [ 11.220062] omap3isp 480bc000.isp: Entity type for entity OMAP3 ISP CSI2a was not initialized! > [ 11.291748] omap3isp 480bc000.isp: Entity type for entity OMAP3 ISP CCDC was not initialized! > [ 11.362152] omap3isp 480bc000.isp: Entity type for entity OMAP3 ISP preview was not initialized! > [ 11.404266] omap3isp 480bc000.isp: Entity type for entity OMAP3 ISP resizer was not initialized! > [ 11.485687] omap3isp 480bc000.isp: Entity type for entity OMAP3 ISP AEWB was not initialized! > [ 11.520874] omap3isp 480bc000.isp: Entity type for entity OMAP3 ISP AF was not initialized! > [ 11.574981] omap3isp 480bc000.isp: Entity type for entity OMAP3 ISP histogram was not initialized! > [ 11.594268] omap3isp 480bc000.isp: parsing parallel interface > [ 106.102905] omap3isp 480bc000.isp: -------------CCDC Register dump------------- > [ 106.110595] omap3isp 480bc000.isp: ###CCDC PCR=0x00000000 > [ 106.116973] omap3isp 480bc000.isp: ###CCDC SYN_MODE=0x00031704 > [ 106.123657] omap3isp 480bc000.isp: ###CCDC HD_VD_WID=0x00000000 > [ 106.129974] omap3isp 480bc000.isp: ###CCDC PIX_LINES=0x00000000 > [ 106.136810] omap3isp 480bc000.isp: ###CCDC HORZ_INFO=0x000004ff > [ 106.143615] omap3isp 480bc000.isp: ###CCDC VERT_START=0x00000000 > [ 106.149932] omap3isp 480bc000.isp: ###CCDC VERT_LINES=0x000003ff > [ 106.156799] omap3isp 480bc000.isp: ###CCDC CULLING=0xffff00ff > [ 106.163299] omap3isp 480bc000.isp: ###CCDC HSIZE_OFF=0x00000a00 > [ 106.169616] omap3isp 480bc000.isp: ###CCDC SDOFST=0x00000000 > [ 106.176086] omap3isp 480bc000.isp: ###CCDC SDR_ADDR=0x40000000 > [ 106.182708] omap3isp 480bc000.isp: ###CCDC CLAMP=0x00000010 > [ 106.188598] omap3isp 480bc000.isp: ###CCDC DCSUB=0x00000000 > [ 106.195068] omap3isp 480bc000.isp: ###CCDC COLPTN=0xbb11bb11 > [ 106.201507] omap3isp 480bc000.isp: ###CCDC BLKCMP=0x00000000 > [ 106.207550] omap3isp 480bc000.isp: ###CCDC FPC=0x00000000 > [ 106.213684] omap3isp 480bc000.isp: ###CCDC FPC_ADDR=0x00000000 > [ 106.219909] omap3isp 480bc000.isp: ###CCDC VDINT=0x03fe02aa > [ 106.226409] omap3isp 480bc000.isp: ###CCDC ALAW=0x00000006 > [ 106.232696] omap3isp 480bc000.isp: ###CCDC REC656IF=0x00000000 > [ 106.238830] omap3isp 480bc000.isp: ###CCDC CFG=0x00008800 > [ 106.244964] omap3isp 480bc000.isp: ###CCDC FMTCFG=0x00000000 > [ 106.251434] omap3isp 480bc000.isp: ###CCDC FMT_HORZ=0x00000000 > [ 106.257568] omap3isp 480bc000.isp: ###CCDC FMT_VERT=0x00000000 > [ 106.264251] omap3isp 480bc000.isp: ###CCDC PRGEVEN0=0x00000000 > [ 106.271606] omap3isp 480bc000.isp: ###CCDC PRGEVEN1=0x00000000 > [ 106.285400] omap3isp 480bc000.isp: ###CCDC PRGODD0=0x00000000 > [ 106.301147] omap3isp 480bc000.isp: ###CCDC PRGODD1=0x00000000 > [ 106.307220] omap3isp 480bc000.isp: ###CCDC VP_OUT=0x00000000 > [ 106.326019] omap3isp 480bc000.isp: ###CCDC LSC_CONFIG=0x00006600 > [ 106.340087] omap3isp 480bc000.isp: ###CCDC LSC_INITIAL=0x00000000 > [ 106.358001] omap3isp 480bc000.isp: ###CCDC LSC_TABLE_BASE=0x00000000 > [ 106.372985] omap3isp 480bc000.isp: ###CCDC LSC_TABLE_OFFSET=0x00000000 > [ 106.379882] omap3isp 480bc000.isp: -------------------------------------------- > [ 118.617980] omap3isp 480bc000.isp: OMAP3 ISP AEWB: user wants to disable module. > [ 118.626068] omap3isp 480bc000.isp: OMAP3 ISP AEWB: module is being disabled > [ 118.633392] omap3isp 480bc000.isp: OMAP3 ISP AF: user wants to disable module. > [ 118.641937] omap3isp 480bc000.isp: OMAP3 ISP AF: module is being disabled > [ 118.649627] omap3isp 480bc000.isp: OMAP3 ISP histogram: user wants to disable module. > [ 118.658508] omap3isp 480bc000.isp: OMAP3 ISP histogram: module is being disabled > root@letux:~# > > >
