Re: [PATCH RESEND 2/2] serial: 8250: omap: Move pm_runtime_get_sync

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

On 10/12/24 3:03 AM, Greg KH wrote:
On Fri, Oct 11, 2024 at 12:33:56PM -0500, Judith Mendez wrote:
Currently in omap_8250_shutdown, the dma->rx_running
flag is set to zero in omap_8250_rx_dma_flush. Next
pm_runtime_get_sync is called, which is a runtime
resume call stack which can re-set the flag. When the
call omap_8250_shutdown returns, the flag is expected
to be UN-SET, but this is not the case. This is causing
issues the next time UART is re-opened and omap_8250_rx_dma
is called. Fix by moving pm_runtime_get_sync before the
omap_8250_rx_dma_flush.

You can go to 72 columns :)

ok, will fix, thanks!


Signed-off-by: Bin Liu <b-liu@xxxxxx>
Signed-off-by: Judith Mendez <jm@xxxxxx>

Wait, who wrote this, Bin?  If so, there needs to be a "From:" line
saying so.

I did not realize I could create a patch for someone, apologies, I
will be sending v3 with correct "From:".


What commit id does this fix?  Do you want it backported to older
kernels?  Why mix two different subsystems in the same patch series, who
is supposed to take it?


I suppose it should be backported to older kernels so I will add back
the fixes tag.

Apologies for sending two different subsystems in one series, I thought
describing as "misc" would be good enough to mix the two, but I can
separate the patches and respin. Thanks.

~ Judith



thanks,

greg k-h





[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux