> -----Original Message----- > From: Russell King - ARM Linux [mailto:linux@xxxxxxxxxxxxxxxx] > Sent: Monday, August 17, 2009 10:21 PM > To: Syed Mohammed, Khasim > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: Exception while handling MEM Hole on OMAP3 / ARM Cortex A8 > > On Mon, Aug 17, 2009 at 04:40:27PM +0530, Syed Mohammed, Khasim wrote: > > This patch seem to be working, I don't see any dump like before. > > Great. > > > Can you please advice on how to get this patch into kernel? I mean, > > will you be handling it or we need to re-submit them with your signed off? > > Yes, I'll be sending it. However, I believe the patch I sent contains > one error: Thanks. > > > +static int __init meminfo_cmp(const void *_a, const void *_b) > > > +{ > > > + const struct membank *a = _a, *b = _b; > > > + long cmp = bank_pfn_start(b) - bank_pfn_start(a); > > I think this should be bank_pfn_start(a) - bank_pfn_start(b). When you > tested this unmodified patch, did the "Memory:" line list the memory > bank sizes in reverse order? Unmodified results in MEM: unordered memory banks. Not freeing memmap. Memory: 60MB 88MB = 148MB total Making it a - b results in Memory: 88MB 60MB = 148MB total a-b is correct one, fortunately both worked for me. Regards, Khasim -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
