On Thu, Sep 12, 2024 at 08:45:15AM -0700, Jakub Kicinski wrote: > On Thu, 12 Sep 2024 10:58:13 +0100 Simon Horman wrote: > > Thanks for pointing that out, and sorry for not thinking of it myself. > > > > Looking over the code, and taking a first pass at implementing this, > > I believe the answer is yes :) > > > > I also think that, as a second step, by using dev_core_stats, > > the custom ndo_get_stats64() implementation can be removed. > > LMKWYT. > > Second step or one conversion patch, no preference. But AFAICT you're > right, the ndo can be completely removed thanks to the conversion. Thanks, I'll see about making it so.