On Tue, Sep 3, 2024 at 4:21 PM Vegard Nossum <vegard.nossum@xxxxxxxxxx> wrote: > > > On 03/09/2024 01:45, Michael Ellerman wrote: > > Vegard Nossum <vegard.nossum@xxxxxxxxxx> writes: > >> Remove the sed script and compile the C source listing structs and > >> offsets to an object file (instead of assembly code) that embeds C source > >> directly. Then extract the C source using objcopy. > >> > > > > I threw some builders at this and hit a few errors: > > Thanks, I also got the ones from kernel test robot and figured something > was going a bit wrong. > > There are several issues: clang wants - instead of /dev/stdout as an > argument to objcopy, and then gcc has some bugs that prevent the numbers > from appearing correctly on some architectures, also I had an extra # in > the COMMENT() macro which only resulted in an error on some > architectures. I've attached a tentative v2 that fixes these issues, but > I'm still trying to figure out why m68k is giving me slightly different > output for include/generated/asm-offsets.h and why the arc assembler > fails. > > In the end I'm wondering if this patch is really worth it, given all the > failures and little workarounds :-| If I can sort out the last few > failures I'll submit it as an RFC. This patch has zero benefit. The current way (preprocess + sed) is faster than your way (preprocess + compile + objcopy) and works independently of tool quirks. -- Best Regards Masahiro Yamada
