On 8/8/24 14:14, Christophe JAILLET wrote:
This file already uses sysfs_emit(). So be consistent and also use sysfs_emit_at(). Moreover, size is always < PAGE_SIZE because scnprintf() (and now sysfs_emit_at()) returns the number of characters written not including the trailing '\0'. So some tests can be removed. This slightly simplifies the code and makes it more readable. Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> --- Compile tested only. 2 spaces are added before color_caps[i].name and color_caps[i].name, but not ctrl_caps[i].name. I wonder if it is done on purpose or if it could be removed as well. --- drivers/video/fbdev/omap/omapfb_main.c | 36 ++++++++++---------------- 1 file changed, 14 insertions(+), 22 deletions(-)
applied. Thanks! Helge
