Re: [PATCH v3 1/9] of: property: add of_graph_get_next_port()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof

> > +		prev = of_get_child_by_name(parent, "ports");
(snip)
> > +		if (!prev) {
> > +			prev = of_node_get(parent);
> > +
> > +			/* check wether it has port node */
> > +			struct device_node *port __free(device_node) =
> > +				of_get_child_by_name(prev, "port");
> > +
> > +			if (!port)
> > +				prev = NULL;
> 
> It looks like you leak here "prev".

Oops, yes ineed.
Thank you for pointing it, will fix it in v4

Best regards
---
Kuninori Morimoto




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux