On Fri, 23 Aug 2024 12:15:57 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > Simplify error handling (less gotos) over locks with guard(). > > The driver used file-scope variable 'irq_state' for storing IRQ state > with spin_lock_irqsave, so move it into respective local scopes. This > should be equivalent, but more readable (less global variables). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > LGTM. File scoped irq_state is certainly unusual... Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxx>
