Hi Roger, Roger Quadros <rogerq@xxxxxxxxxx> writes: > On 31/07/2024 22:12, Rob Herring (Arm) wrote: >> Use of_property_present() to test for property presence rather than >> of_get_property(). This is part of a larger effort to remove callers >> of of_get_property() and similar functions. of_get_property() leaks >> the DT property data pointer which is a problem for dynamically >> allocated nodes which may be freed. >> >> The code was also incorrectly assigning the return value to a 'struct >> property' pointer. It didn't matter as "prop" was never dereferenced. >> >> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > > Reviewed by: Roger Quadros <rogerq@xxxxxxxxxx> just FYI, missing a '-' in your Reviewed-by, which means tools like b4 will not spot it. I added it manually this time cuz I happened to notice it was missing. Kevin
