> -----Original Message----- > From: Samuel Ortiz [mailto:sameo@xxxxxxxxxxxxxxx] > On Mon, Aug 17, 2009 at 10:46:55AM +0530, Krishnamoorthy, Balaji T wrote: > > > From: Samuel Ortiz [mailto:sameo@xxxxxxxxxxxxxxx] > > > * Why are you moving twl_init_irq and twl_exit_irq to twl.h ? > > > > > twl_init_irq and twl_exit_irq is defined in twl4030-irq.c and called from > > twl-core.c. Earlier twl4030-core.c had declaration too. > You're now exporting those 2 routines from a include/linux/ header, and I > still dont understand why. My assumption was that declaration has to be in .h file. But since these two functions are called only from twl-core.c files, I can keep it as before, without moving to twl.h -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html