Hi,
On Thu, Jun 06, 2024 at 07:51:04PM +0300, Andy Shevchenko wrote:
> Let the kememdup_array() take care about multiplication and possible
^^^^^
Typo.
> overflows.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> arch/arm/mach-omap2/omap_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
> index fca7869c8075..800980057373 100644
> --- a/arch/arm/mach-omap2/omap_device.c
> +++ b/arch/arm/mach-omap2/omap_device.c
> @@ -315,7 +315,7 @@ static struct omap_device *omap_device_alloc(struct platform_device *pdev,
>
> od->hwmods_cnt = oh_cnt;
>
> - hwmods = kmemdup(ohs, sizeof(struct omap_hwmod *) * oh_cnt, GFP_KERNEL);
> + hwmods = kmemdup_array(ohs, oh_cnt, sizeof(*hwmods), GFP_KERNEL);
Maybe same result, but I guess the 3rd parameter should be count?
A.
