On Tue, May 21, 2024 at 11:45:28AM +0530, Onkarnarth wrote: > From: Onkarnath <onkarnath.1@xxxxxxxxxxx> nitpick: In $subject: s/Refactoring/Refactor to follow the convention of using imperative mood. > > As %pe is already introduced, it's better to use it in place of (%ld) or > (%d) for printing error in logs. It will enhance readability of logs. > > Error print style is more consistent now. > > Suggested-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Co-developed-by: Maninder Singh <maninder1.s@xxxxxxxxxxx> > Signed-off-by: Maninder Singh <maninder1.s@xxxxxxxxxxx> > Signed-off-by: Onkarnath <onkarnath.1@xxxxxxxxxxx> Thank you for the patch. LGTM. Reviewed-by: Siddharth Vadapalli <s-vadapalli@xxxxxx> > --- > Suggested by Bjorn Helgaas in below discussion > https://patchwork.kernel.org/comment/25712288/ > > v1 -> v2: Added suggested by tag > > drivers/pci/bus.c | 2 +- > drivers/pci/controller/dwc/pci-dra7xx.c | 2 +- > drivers/pci/controller/dwc/pci-meson.c | 16 +-- > drivers/pci/controller/dwc/pcie-armada8k.c | 4 +- > drivers/pci/controller/dwc/pcie-histb.c | 6 +- > drivers/pci/controller/dwc/pcie-intel-gw.c | 10 +- > drivers/pci/controller/dwc/pcie-keembay.c | 2 +- > drivers/pci/controller/dwc/pcie-kirin.c | 6 +- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 18 +-- > drivers/pci/controller/dwc/pcie-qcom.c | 18 +-- > drivers/pci/controller/dwc/pcie-tegra194.c | 132 +++++++++--------- > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 2 +- > drivers/pci/controller/pci-aardvark.c | 6 +- > drivers/pci/controller/pci-ftpci100.c | 2 +- > drivers/pci/controller/pci-tegra.c | 86 ++++++------ > drivers/pci/controller/pci-xgene.c | 4 +- > drivers/pci/controller/pcie-microchip-host.c | 2 +- > drivers/pci/controller/pcie-rcar-host.c | 14 +- > drivers/pci/controller/pcie-rockchip.c | 34 ++--- > drivers/pci/controller/vmd.c | 2 +- > drivers/pci/doe.c | 4 +- > drivers/pci/endpoint/functions/pci-epf-mhi.c | 8 +- > drivers/pci/endpoint/functions/pci-epf-ntb.c | 2 +- > drivers/pci/endpoint/functions/pci-epf-test.c | 4 +- > drivers/pci/endpoint/functions/pci-epf-vntb.c | 2 +- > drivers/pci/endpoint/pci-ep-cfs.c | 12 +- > drivers/pci/endpoint/pci-epf-core.c | 16 +-- > drivers/pci/hotplug/acpiphp_core.c | 2 +- > drivers/pci/hotplug/pciehp_core.c | 8 +- > drivers/pci/hotplug/shpchp_core.c | 4 +- > drivers/pci/of.c | 6 +- > drivers/pci/pci-driver.c | 4 +- > drivers/pci/pcie/dpc.c | 4 +- > drivers/pci/quirks.c | 2 +- > drivers/pci/setup-bus.c | 2 +- > drivers/pci/slot.c | 4 +- > drivers/pci/vgaarb.c | 2 +- > 37 files changed, 227 insertions(+), 227 deletions(-) > [...] Regards, Siddharth.
