Hi, On Tue, Mar 26, 2024 at 08:26:54AM +0100, Krzysztof Kozlowski wrote: > On 25/03/2024 22:45, Sebastian Reichel wrote: > > Convert the legacy txt binding to modern YAML. > > No semantic change. > > You deprecated a property: ti,hwmods. Also will be one more change: > ti,ssi-cawake-gpio->gpios and I will introduce a simple bus binding for referencing the peripheral. I added a list to the commit message for v2. > > Documentation/devicetree/bindings/hsi/omap-ssi.txt | 102 ----------- > > .../devicetree/bindings/hsi/ti,omap-ssi.yaml | 196 +++++++++++++++++++++ > > 2 files changed, 196 insertions(+), 102 deletions(-) [...] > > +patternProperties: > > + "[hs]si-port@[0-9a-f]+": > > Does anything actually depends on the name? Can these be "port@[0-9a-f]+"? That should work. The Linux driver is looping over all child nodes and checking the compatible. [...] > > + ti,ssi-cawake-gpio: > > ti,ssi-cawake-gpios mh, the kernel supports the extra s since 2016. I guess that should be good enough. I will fix it in v2. All other comments will be fixed in v2. Thanks for the review, -- Sebastian
Attachment:
signature.asc
Description: PGP signature
