Hi, On Mar 04, 2024 at 16:35:45 +0100, Thomas Richard wrote: > The goal is to extend the active period of pinctrl. > Some devices may need active pinctrl after suspend() and/or before > resume(). > So move suspend()/resume() to suspend_noirq()/resume_noirq() in order to > have active pinctrl until suspend_noirq() (included), and from > resume_noirq() (included). > > The deprecated API has been removed to use the new one (dev_pm_ops struct). > > No need to check the pointer returned by dev_get_drvdata(), as > platform_set_drvdata() is called during the probe. > > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Signed-off-by: Thomas Richard <thomas.richard@xxxxxxxxxxx> > --- I was planning to do this but didn't see particular benefit to it. Do you see the benefit on your specific device? Can you help me understand how? Not against the patch, just curious. Reviewed-by: Dhruva Gole <d-gole@xxxxxx> -- Best regards, Dhruva
