Re: [PATCH v1 1/1] PCI: dwc: Remove unused of_gpio.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 08, 2024 at 03:25:47PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Mar 07, 2024 at 02:28:40PM +0200, Andy Shevchenko wrote:
> > of_gpio.h is deprecated and subject to remove.
> > The driver doesn't use it, simply remove the unused header.

> What about the rest?
> 
> drivers/pci/controller/dwc/pcie-kirin.c
> drivers/pci/controller/dwc/pci-imx6.c

Have you chance to look at them?

> There is also one non-dwc driver:
> 
> drivers/pci/controller/pci-aardvark.c

Keyword: non-dwc.
This patch is for DesignWare controllers that confirmed not using the header.

> It is better to remove it from all PCI drivers in a single patch.

I disagree on this. These are different drivers and even inside DesignWare not
all of them can be converted with a simple change like this one.

That said, please consider applying this one as is.

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux