Hi Thomas, ... > - struct pcs_device *pcs; > - > - pcs = platform_get_drvdata(pdev); > - if (!pcs) > - return -EINVAL; > + struct pcs_device *pcs = dev_get_drvdata(dev); I think this cleanup can be placed in a different patch. Besides, it's not mentioned in the commit log. Otherwise looks good. Andi