Re: [PATCH 1/3] arch/arm/boot/dts/dra7-l4.dtsi: add missing unit addresse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Le 22/01/2024 à 18:11, Conor Dooley a écrit :
> On Mon, Jan 22, 2024 at 12:19:46PM +0100, Romain Naour wrote:
>> From: Romain Naour <romain.naour@xxxxxxx>
>> phy_gmii_sel node have 'reg' so it must have unit address.
>> Fixes:
>> Warning (unit_address_vs_reg): /ocp/interconnect@4a000000/segment@0/target-module@2000/scm@0/scm_conf@0/phy-gmii-sel: node has a reg or ranges property, but no unit name
> Does checkpatch not complain about this "Fixes" tag?

No, but there is a warning due to the too long line.
I removed the Fixes tag.

> Also, for all patches in your series, the subject is odd. Running
> `git log` on the files you're changing is a good idea to get off to a
> good start with a subject line.

You're right.

Best regards,

> Thanks,
> Conor.
>> Signed-off-by: Romain Naour <romain.naour@xxxxxxx>

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux