Re: [PATCH 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 09/01/2024 20:04, Andrew Davis wrote:
> On 1/9/24 12:59 PM, Krzysztof Kozlowski wrote:
>> On 09/01/2024 18:19, Andrew Davis wrote:
>>> This binding will be used for GPUs starting from Series6 (Rogue)
>>> and later. A different binding document will describe Series5.
>>> With that the name "img,powervr" is too generic, rename to
>>> "img,powervr-rogue" to avoid confusion.
>>> Suggested-by: Maxime Ripard <mripard@xxxxxxxxxx>
>>> Signed-off-by: Andrew Davis <afd@xxxxxx>
>>> Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
>>> Reviewed-by: Frank Binns <frank.binns@xxxxxxxxxx>
>>> ---
>> Why do you send new version while we still talk about previous?
>> Please implement feedback from v1 (and this is v2, so next is v3) or
>> keep discussing.
> I agreed with everything you said in the last round (RFC v2) and
> made all requested changes. Did I miss something in this version?

The recommendation is that naming of the file matches generic compatible
and your file has only one generic compatible. Therefore I don't
understand why you claimed there are multiple compatibles.

Best regards,

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux