> Am 05.12.2023 um 07:57 schrieb Maxime Ripard <mripard@xxxxxxxxxx>: > > On Mon, Dec 04, 2023 at 12:22:36PM -0600, Andrew Davis wrote: >> The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from >> multiple vendors. Describe how the SGX GPU is integrated in these SoC, >> including register space and interrupts. Clocks, reset, and power domain >> information is SoC specific. >> >> Signed-off-by: Andrew Davis <afd@xxxxxx> >> --- >> .../devicetree/bindings/gpu/img,powervr.yaml | 69 +++++++++++++++++-- >> 1 file changed, 63 insertions(+), 6 deletions(-) > > I think it would be best to have a separate file for this, img,sgx.yaml > maybe? Why? The whole family of IMG GPUs is PowerVR and SGX and Rogue are generations 5 and 6++: https://en.wikipedia.org/wiki/PowerVR So I would suggest to keep either img,powervr.yaml for all of them or img,powervr-sgx.yaml img,powervr-rogue.yaml etc. But as far as I can see the hardware integration into SoC (and hence description) is quite similar so a single file should suffice. BR, Nikolaus
