On Thu, 23 Nov 2023, Péter Ujfalusi wrote:
>
>
> On 23/11/2023 12:41, Lee Jones wrote:
> >>> @@ -368,10 +368,10 @@ int twl6030_init_irq(struct device *dev, int irq_num)
> >>> int nr_irqs;
> >>> int status;
> >>> u8 mask[3];
> >>> - const int *irq_tbl;
> >>> + const struct of_device_id *of_id;
> >>>
> >>> - irq_tbl = device_get_match_data(dev);
> >>> - if (!irq_tbl) {
> >>> + of_id = of_match_device(twl6030_of_match, dev);
> >>
> >> I think you just dropped support for ACPI.
> >
> > Ah, scrap that. I was looking at the wrong part of 1e0c866887f4.
> >
> > So what about the other drivers changed in the aforementioned commit?
>
> Looking back at it again, I think only this patch is needed.
> This is not a real driver, it is using the twl core's device.
> The twl6030 is for sure broken, let me reply to the twl4030-power in a sec.
>
> > Ideally we'd have a call that covers all of the various probing APIs.
> >
> >> Rob, care to follow-up?
Rob, last chance to state your case before I apply it.
--
Lee Jones [李琼斯]
