On Mon, Oct 23, 2023 at 7:14 PM Jacob Keller <jacob.e.keller@xxxxxxxxx> wrote: > > > > On 10/22/2023 8:19 AM, Adam Ford wrote: > > Currently there is a device tree entry called "local-mac-address" > > which can be filled by the bootloader or manually set.This is > > useful when the user does not want to use the MAC address > > programmed into the SoC. > > > > Currently, the davinci_emac reads the MAC from the DT, copies > > it from pdata->mac_addr to priv->mac_addr, then blindly overwrites > > it by reading from registers in the SoC, and falls back to a > > random MAC if it's still not valid. This completely ignores any > > MAC address in the device tree. > > > > In order to use the local-mac-address, check to see if the contents > > of priv->mac_addr are valid before falling back to reading from the > > SoC when the MAC address is not valid. > > > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> > > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> > > --- > > V2: Rebase, add R-B tag, and post stand-alone for netdev branch, since > > the device tree patch has already been accepted via the omap tree. > > Looks like you didn't add the tag for which tree. Given the context, I > would assume net-next. > That was my intent. I sent the e-mail to netdev and CC'd others. I thought that was enough. > Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>
