Rajendra, <snip> > >> +#define OMAP4430_CM1_BASE 0x4a004000 > >> +#define OMAP4430_CM_BASE OMAP4430_CM1_BASE > > > >Why do you need 2 defines for the same value? > > Hi Sergio, > PRCM had just one CM module in OMAP2/3 and OMAP4 has > 2 of them , CM1 and CM2. That I can understand... > The older CM defines are now mapped to CM1 > for OMAP4 and new ones created for CM2. Ok, but if you're trying to set that convention, IMHO either keep one or the another. For example, you can keep only this definition: #define OMAP4430_CM1_BASE 0x4a004000 And change in all the currently merged code from CM to CM1... Anyways, its just my thoughts... Of course you're free to take them or not. Thanks and Regards, Sergio > > regards, > Rajendra > > > >Regards, > >Sergio > > > >> +#define OMAP4430_CM2_BASE 0x4a008000 > >> +#define OMAP4430_PRM_BASE 0x4a306000 > >> #define OMAP44XX_GPMC_BASE 0x50000000 > >> #define OMAP443X_SCM_BASE 0x4a002000 > >> #define OMAP443X_CTRL_BASE OMAP443X_SCM_BASE > >> -- > >> 1.5.4.7 > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe > >linux-omap" in > >> the body of a message to majordomo@xxxxxxxxxxxxxxx > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
