On Tue, Oct 10, 2023 at 3:27 AM Chen-Yu Tsai <wens@xxxxxxxx> wrote: > > On Tue, Oct 10, 2023 at 5:14 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > Use preferred device_get_match_data() instead of of_match_device() to > > get the driver match data. With this, adjust the includes to explicitly > > include the correct headers. > > > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > drivers/mfd/axp20x.c | 22 +++------------------- > > I'd keep the error message, but otherwise for axp20x, Why? It can't happen. We already matched successfully in order to probe, so matching again in probe is redundant and won't fail. > Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx> Thanks. Rob
