* H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> [231007 06:54]: > Hi Tony, > > > Am 07.10.2023 um 08:44 schrieb Tony Lindgren <tony@xxxxxxxxxxx>: > > > > * H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> [231004 12:50]: > >> What about the PVR/SGX driver. This needs a compatible that can distinguish > >> between the DM3725 and DM3730. The first is w/o SGX and the second one > >> with. Having all summarized as omap3630 does not allow to load the > >> PVR/SGX driver based on the board specific compatible entry. > >> > >> AFAIR this was the original idea behind > >> > >> compatible = "goldelico,gta04", "ti,omap3630", "ti,omap36xx", "ti,omap3"; > > > > I think we already handle this, see drivers/bus/ti-sysc.c and search for > > DIS_SGX and similar flags for other accelerators. > > Ah, ok. This means that the kernel module isn't loaded if the flags of the chip > are not available. Then we will indeed have no need to describe such variances > in the DTS. > > > So I think this patch is > > safe to apply? > > Looks so (especially as I only have omap3630 based devices with SGX). OK applying into omap-for-v6.7/dt then. Thanks, Tony
