On Thu, 28 Sep 2023 16:00:00 +0530 MD Danish Anwar wrote: > +/** > + * Config state machine variables. See IEEE Std 802.1Q-2018 8.6.8.4 > + */ Please use correct kdoc format with all members documented or not use the /** marker. > +struct tas_config_list { > + /* New list is copied at this time */ > + u64 config_change_time; > + /* config change error counter, incremented if > + * admin->BaseTime < current time and TAS_enabled is true > + */ > + u32 config_change_error_counter; > + /* True if list update is pending */ > + u8 config_pending; > + /* Set to true when application trigger updating of admin list > + * to active list, cleared when configChangeTime is updated > + */ > + u8 config_change; > +}; -- pw-bot: cr