Hi Linus, Tony, Dnia wtorek, 26 września 2023 09:09:53 CEST Tony Lindgren pisze: > * Linus Walleij <linus.walleij@xxxxxxxxxx> [230912 08:45]: > > The OMAP GPIO driver hardcodes the MPIO chip base, but there > > is no point: we have already moved all consumers over to using > > descriptor look-ups. > > > > Drop the MPUIO GPIO base and use dynamic assignment. On my OMAP1510 based ams_delta with the patch applied on top of v6.6-rc4: root@amsdelta:~# cat /sys/kernel/debug/gpio gpiochip0: GPIOs 512-527, parent: platform/omap_gpio.0, mpuio: gpio-512 ( |data ) in lo gpio-513 ( |data ) in lo gpio-514 ( |data ) in lo gpio-515 ( |data ) in lo gpio-516 ( |data ) in lo gpio-517 ( |data ) in lo gpio-518 ( |data ) in lo gpio-519 ( |data ) in lo gpiochip1: GPIOs 528-543, parent: platform/omap_gpio.1, gpio-0-15: gpio-528 ( |keybrd_data ) in lo gpio-529 ( |keybrd_clk ) in lo IRQ gpio-530 ( |modem_irq ) in lo gpio-532 ( |hook_switch ) in hi IRQ gpio-540 ( |rdy ) in hi gpiochip2: GPIOs 544-551, parent: platform/basic-mmio-gpio.0, latch1: gpio-544 ( |camera ) out lo ... GPIO based hardware seems to be working correctly. I'm only not sure if we should maybe change the name to something else than gpio-0-15 (mpuio looks OK). > > > > Root out the unused instances of the OMAP_MPUIO() macro and > > delete the unused OMAP_GPIO_IS_MPUIO() macro. > > > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > --- > > Maybe Bartosz can merge this into the GPIO tree with Tony's > > et al blessing? > > Best to wait for Tested-by from Aaro on this one. > > As far as I'm concerned, good to see this: > > Reviewed-by: Tony Lindgren <tony@xxxxxxxxxxx> Tested-by: Janusz Krzysztofik <jmkrzyszt@xxxxxxxxx>
Attachment:
signature.asc
Description: This is a digitally signed message part.
