Re: [PATCH 2/3] clk: twl: add clock driver for TWL6032

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Thu, 24 Aug 2023 09:04:28 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:

> >>> +
> >>> +MODULE_DESCRIPTION("Clock driver for TWL Series Devices");
> >>> +MODULE_ALIAS("platform:twl-clk");    
> >>
> >> This alias is unnecessary?
> >>  
> > The question is whether this driver should have a separate dt
> > node (and if a separate node, then one per clock as the clk-palmas
> > driver) or not. See Rob's review of the binding document.
> > So we have basically #clock-cells = <1>; in the twl parent
> > and a call to mfd_add_device() there in the former case and I guess
> > that alias is needed then.
> >   
> You should not need the alias in any of these cases. platform alias for
> platform driver means you have incomplete tables and use alias instead
> of tables. Preference is to use tables.

Is there a general consensus that MODULE_ALIAS("platform:.*") should be
exorcised? Of course for this new driver I will avoid it now anyways.


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux