On 24/08/23 12:13 pm, Krzysztof Kozlowski wrote: > On 23/08/2023 13:32, MD Danish Anwar wrote: >> Add a DT binding document for the ICSS Industrial Ethernet Peripheral(IEP) >> hardware. IEP supports packet timestamping, PTP and PPS. >> >> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Really? Where? > >> Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx> > > Now you are making things up. Please stop faking tags. > >> Reviewed-by: Simon Horman <horms@xxxxxxxxxx> > > Where? > >> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx> >> --- >> .../devicetree/bindings/net/ti,icss-iep.yaml | 61 +++++++++++++++++++ >> 1 file changed, 61 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> new file mode 100644 >> index 000000000000..75668bea8614 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> @@ -0,0 +1,61 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module >> + >> +maintainers: >> + - Md Danish Anwar <danishanwar@xxxxxx> >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - enum: >> + - ti,am642-icss-iep >> + - ti,j721e-icss-iep >> + - const: ti,am654-icss-iep >> + >> + - const: ti,am654-icss-iep >> + >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + description: phandle to the IEP source clock >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + > > Drop stray blank line > I will drop this blank line. >> + /* AM65x */ >> + icssg0_iep0: iep@2e000 { >> + compatible = "ti,am654-icss-iep"; >> + reg = <0x2e000 0x1000>; >> + clocks = <&icssg0_iepclk_mux>; >> + }; > > Choose one example. > I will only keep one example (AM65x) and drop other examples. > > Best regards, > Krzysztof > I will make above changes and remove Roger's RB from patch 3 and 4 as he is the author of those patches. With these changes I will send next revision today. If there is anything else, please let me know. -- Thanks and Regards, Danish.
