On Fri, Aug 18, 2023 at 05:30:09PM +0800, Li Zetao wrote: > Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for > prepared and enabled clocks"), devm_clk_get() and clk_prepare_enable() > can now be replaced by devm_clk_get_enabled() when the driver enables > (and possibly prepares) the clocks for the whole lifetime of the device. > Moreover, it is no longer necessary to unprepare and disable the clocks > explicitly. It seems it fixes a bug that we try to remove the enabled clock on unbinding. Maybe Tony can shed a light here. If this is the case, add a Fixes tag. Otherwise it might be (undesired?) functional change and in any case has to be mentioned in the commit message. -- With Best Regards, Andy Shevchenko