Re: Warnings: pm branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Hemanth V" <hemanthv@xxxxxx> writes:

> ----- Original Message ----- 
> From: "Kevin Hilman" <khilman@xxxxxxxxxxxxxxxxxxx>
>>>  /* enter the state and update stats */
>>> @@ -91,6 +93,12 @@ static void cpuidle_idle_call(void)
>>>  /* give the governor an opportunity to reflect on the outcome */
>>>  if (cpuidle_curr_governor->reflect)
>>>  cpuidle_curr_governor->reflect(dev);
>>> +
>>> + return;
>>> +
>>
>> ... I think you want to drop this return.  If it returns here, it
>> will still not enable IRQs.  I think it should just fall through
>> to the enable and return.
>
> Since omap3_enter_idle returns with interrupts enabled, I had
> added this return. We could remove it also for safety purposes.
 
OK.  I think you should post to linux-pm for comment, and possibly
raise this as a question.

You can add:

Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux