On 08/08/23 5:38 pm, Conor Dooley wrote: > On Mon, Aug 07, 2023 at 04:30:43PM +0530, MD Danish Anwar wrote: >> This series introduces Industrial Ethernet Peripheral (IEP) driver to >> support timestamping of ethernet packets and thus support PTP and PPS >> for PRU ICSSG ethernet ports. >> >> This series also adds 10M full duplex support for ICSSG ethernet driver. >> >> There are two IEP instances. IEP0 is used for packet timestamping while IEP1 >> is used for 10M full duplex support. >> >> This is v2 of the series [v1]. It addresses comments made on [v1]. >> This series is based on linux-next(#next-20230807). >> >> Changes from v1 to v2: >> *) Addressed Simon's comment to fix reverse xmas tree declaration. Some APIs >> in patch 3 and 4 were not following reverse xmas tree variable declaration. >> Fixed it in this version. >> *) Addressed Conor's comments and removed unsupported SoCs from compatible >> comment in patch 1. > > I'm sorry I missed responding there before you sent v2, it was a bank > holiday yesterday. I'm curious why you removed them, rather than just > added them with a fallback to the ti,am654-icss-iep compatible, given > your comment that "the same compatible currently works for all these > 3 SoCs". I removed them as currently the driver is being upstreamed only for AM654x, once I start up-streaming the ICSSG driver for AM64 and any other SoC. I will add them here. If at that time we are still using same compatible, then I will modify the comment otherwise add new compatible. As of now, I don't see the need of adding other SoCs in iep binding as IEP driver up-streaming is only planned for AM654x as of now. > > Thanks, > Conor. > >> *) Addded patch 2 which was not part of v1. Patch 2, adds IEP node to dt >> bindings for ICSSG. >> >> [v1] https://lore.kernel.org/all/20230803110153.3309577-1-danishanwar@xxxxxx/ >> >> Thanks and Regards, >> Md Danish Anwar >> >> Grygorii Strashko (1): >> net: ti: icssg-prueth: am65x SR2.0 add 10M full duplex support >> >> MD Danish Anwar (1): >> dt-bindings: net: Add iep node in ICSSG driver dt binding >> >> Md Danish Anwar (1): >> dt-bindings: net: Add ICSS IEP >> >> Roger Quadros (2): >> net: ti: icss-iep: Add IEP driver >> net: ti: icssg-prueth: add packet timestamping and ptp support >> >> .../devicetree/bindings/net/ti,icss-iep.yaml | 37 + >> .../bindings/net/ti,icssg-prueth.yaml | 7 + >> drivers/net/ethernet/ti/Kconfig | 12 + >> drivers/net/ethernet/ti/Makefile | 1 + >> drivers/net/ethernet/ti/icssg/icss_iep.c | 961 ++++++++++++++++++ >> drivers/net/ethernet/ti/icssg/icss_iep.h | 41 + >> drivers/net/ethernet/ti/icssg/icssg_config.c | 6 + >> drivers/net/ethernet/ti/icssg/icssg_ethtool.c | 21 + >> drivers/net/ethernet/ti/icssg/icssg_prueth.c | 433 +++++++- >> drivers/net/ethernet/ti/icssg/icssg_prueth.h | 28 +- >> 10 files changed, 1540 insertions(+), 7 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> create mode 100644 drivers/net/ethernet/ti/icssg/icss_iep.c >> create mode 100644 drivers/net/ethernet/ti/icssg/icss_iep.h >> >> -- >> 2.34.1 >> -- Thanks and Regards, Danish.
