On Tue, Aug 08, 2023 at 03:14:31PM +0530, Md Danish Anwar wrote: > Hi Conor, > > On 07/08/23 8:09 pm, Conor Dooley wrote: > > On Mon, Aug 07, 2023 at 04:38:36PM +0530, MD Danish Anwar wrote: > >> Add interrupts and interrupt-names protperties for PRU and RTU cores. > >> > >> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx> > >> --- > >> .../bindings/remoteproc/ti,pru-rproc.yaml | 22 +++++++++++++++++++ > >> 1 file changed, 22 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > >> index cd55d80137f7..6970316943bb 100644 > >> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > >> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > >> @@ -66,6 +66,16 @@ properties: > >> Should contain the name of the default firmware image > >> file located on the firmware search path. > >> > >> + interrupts: > >> + maxItems: 1 > >> + description: > >> + Interrupt specifiers enable the virtio/rpmsg communication between MPU > >> + and the PRU/RTU cores. > >> + > >> + interrupt-names: > >> + items: > >> + - const: vring > >> + > >> if: > >> properties: > >> compatible: > >> @@ -171,6 +181,9 @@ examples: > >> <0x22400 0x100>; > >> reg-names = "iram", "control", "debug"; > >> firmware-name = "am65x-pru0_0-fw"; > >> + interrupt-parent = <&icssg0_intc>; > >> + interrupts = <16 2 2>; > >> + interrupt-names = "vring"; > >> }; > > > > These examples would probably be more helpful if they used the > > appropriate defines, no? > > > > PRUSS Interrupt controller doesn't have any appropriate defines. This doesn't > use GIC so defines from arm-gic.h can not be used here. These are specific to > PRUSS INTC. I was deliberately vague in case the gic stuff applied too, but my main question was about the standard defines used for interrupt types. > I think these example are OK. Please let me know if this is OK to you.
Description: PGP signature