On Thu, Jul 27, 2023 at 07:57:04PM +0800, Ruan Jinjie wrote:
> There is no need to call the dev_err_probe() function directly to print
> a custom message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
...
> @@ -1415,7 +1415,7 @@ static int omap_gpio_probe(struct platform_device *pdev)
> if (bank->irq <= 0) {
> if (!bank->irq)
> bank->irq = -ENXIO;
> - return dev_err_probe(dev, bank->irq, "can't get irq resource\n");
> + return bank->irq;
> }
Actually you may go further here and drop a dead code:
if (bank->irq < 0)
return bank->irq;
will suffice.
--
With Best Regards,
Andy Shevchenko
