Re: [PATCH -next] gpio: Remove redundant dev_err_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 27, 2023 at 05:14:46PM +0800, Ruan Jinjie wrote:
> There is no need to call the dev_err_probe() function directly to print
> a custom message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.

Please, split on per-driver basis.
The code wise it's okay, you may add to each patch in v2
Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

>  drivers/gpio/gpio-davinci.c | 2 +-
>  drivers/gpio/gpio-omap.c    | 2 +-

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux